Removed OptionsResolverInterface usage #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because [OptionsResolverInterface is deprecated](http://api.symfony.com/3.0/Symfony/Component/OptionsResolver/OptionsResolverInterface.html), it's now better to use `OptionsResolver`.
|
Since there is no test at all on the Form folder, maybe it could a good idea to add some? |
K-Phoen
reviewed
Oct 9, 2017
| @@ -18,7 +17,7 @@ public function configureOptions(OptionsResolver $resolver) | |||
| $this->setDefaultOptions($resolver); | |||
| } | |||
|
|
|||
| public function setDefaultOptions(OptionsResolverInterface $resolver) | |||
| public function setDefaultOptions(OptionsResolver $resolver) | |||
There was a problem hiding this comment.
Nice catch 👍
Aren't we also supposed to define the configureOptions method instead of setDefaultOptions? (cf: https://symfony.com/doc/2.8/forms.html#creating-form-classes)
There was a problem hiding this comment.
Note to self: it's already defined in the file (and it calls setDefaultOptions).
It's probably done this way to ensure BC for Symfony <2.8. I'll make sure that it's really necessary to maintain compatibility for <2.8 and if not, I'll cleanup the code.
|
You're right, I'll see to add a few tests :) |
|
Thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because OptionsResolverInterface is deprecated, it's now better to use
OptionsResolver.