Fixes a bug where you cannot use a runtime operator in a SQL query #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just drop a quick comment to say that I saw your PR and will definitely review it, but that I won't be able to do it before at least a couple of weeks (due to a lack of time). Thanks for the PR and sorry for the inconvenience :| |
|
Sure. It's not in a state that can be merged it was more to see if you agreed with the general approach then we'll wrap it up. |
|
Do you have any feedback on this? |
|
Ping |
iainmckay
force-pushed
the
runtime-sql-operator
branch
3 times, most recently
from
a345f6f
to
f9bbb47
Compare
iainmckay
force-pushed
the
runtime-sql-operator
branch
2 times, most recently
from
f822b93
to
61bc703
Compare
iainmckay
force-pushed
the
runtime-sql-operator
branch
from
61bc703
to
9931438
Compare
iainmckay
force-pushed
the
runtime-sql-operator
branch
from
9931438
to
d60a9c1
Compare
iainmckay
force-pushed
the
runtime-sql-operator
branch
from
d60a9c1
to
25db7d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix the bug documented in #40. As you stated, it wasn't a trivial fix and our fix is, unfortunately, a bit disruptive.
This introduces a few new objects to track what type of operators are being created so that they can be formatted correctly when they are written out to a cache. Breaking out of strings is a bit messy but it was the most straightforward method we could find to solve the issue.
We've only confirmed that the native and DoctrineORM targets work right now as that is what we use in our project. I'd like feedback on our approach but we do intend on fixing the other targets and tests to work.