Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dependencies creation. #10

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Simplify dependencies creation. #10

merged 1 commit into from
Oct 9, 2018

Conversation

K0Te
Copy link
Owner

@K0Te K0Te commented Oct 9, 2018 •
edited
Loading

First refactoring step for #3, this will allow to extract converters to separate classes.

@K0Te K0Te self-assigned this Oct 9, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18

  • 26 of 36 (72.22%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.4%) to 84.328%
Changes Missing Coverage Covered Lines Changed/Added Lines %
django_object_manager/object_manager.py 26 36 72.22%
Files with Coverage Reduction New Missed Lines %
django_object_manager/object_manager.py 1 84.09%
Totals Coverage Status
Change from base Build 16: -2.4%
Covered Lines: 113
Relevant Lines: 134
💛 - Coveralls

@K0Te K0Te merged commit e3c5f4c into master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@K0Te K0Te

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@K0Te @coveralls