Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transform.py because of RuntimeError #421

Merged
merged 1 commit into from May 22, 2023

Conversation

xenolex
Copy link
Contributor

@xenolex xenolex commented May 19, 2023

Got
RuntimeError: dictionary changed size during iteration on locals iteration, because locals, change when you iter over them,

Got
RuntimeError: dictionary changed size during iteration
on locals iteration, because locals, change when you iter over them,
@xenolex
Copy link
Contributor Author

xenolex commented May 21, 2023

@artur-trzesiok please take a look

Copy link
Contributor

@tgandor tgandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we need to copy the locals() dictionary, but it's OK with me.

@tgandor
Copy link
Contributor

tgandor commented May 22, 2023

Oops, you've just written above, that locals() is modified during iteration; I thought that it returned a 'read-only' view of the local scope, and not the real dict instead. @artur-trzesiok this should be merged.

@artur-trzesiok artur-trzesiok changed the base branch from main to devel May 22, 2023 16:07
@artur-trzesiok
Copy link
Collaborator

@xenolex Thanks for good spoting and Fix! @tgandor thanks for verification!

@artur-trzesiok artur-trzesiok merged commit 0d041ea into K3D-tools:devel May 22, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants