Fix clearing selection

clearFrameData was a hack not really clearing the selection.
This is no longer required as we now support decorations without
selection.

common/remoteviewinterface.h

@@ -81,7 +81,6 @@ public slots:
     void reset();
     void elementsAtReceived(const GammaRay::ObjectIds &ids, int bestCandidate);
     void frameUpdated(const GammaRay::RemoteViewFrame &frame);
-    void requestClearFrameData();
 
 private:
     QString m_name;

core/remoteviewserver.cpp

@@ -78,13 +78,6 @@ void RemoteViewServer::resetView()
         emit reset();
 }
 
-
-void RemoteViewServer::clearFrameData()
-{
-    if (isActive())
-        emit requestClearFrameData();
-}
-
 bool RemoteViewServer::isActive() const
 {
     return m_clientActive;

core/remoteviewserver.h

@@ -61,9 +61,6 @@ class GAMMARAY_CORE_EXPORT RemoteViewServer : public RemoteViewInterface
     /// resets the client view if the window selection changed
     void resetView();
 
-    /// clear the client current frame data
-    void clearFrameData();
-
     /// returns @c true if there is a client displaying our content
     bool isActive() const;
 

plugins/quickinspector/quickinspector.cpp

@@ -541,13 +541,7 @@ void QuickInspector::checkServerSideDecorations()
 
 void QuickInspector::itemSelectionChanged(const QItemSelection &selection)
 {
-    if (selection.isEmpty()) {
-        m_overlay->placeOn(ItemOrLayoutFacade());
-        m_remoteView->clearFrameData();
-        return;
-    }
-
-    const QModelIndex index = selection.first().topLeft();
+    const QModelIndex index = selection.value(0).topLeft();
     m_currentItem = index.data(ObjectModel::ObjectRole).value<QQuickItem *>();
     m_itemPropertyController->setObject(m_currentItem);
 

ui/remoteviewwidget.cpp

@@ -117,7 +117,6 @@ void RemoteViewWidget::setName(const QString &name)
     connect(m_interface, SIGNAL(elementsAtReceived(GammaRay::ObjectIds,int)), this, SLOT(elementsAtReceived(GammaRay::ObjectIds,int)));
     connect(m_interface, SIGNAL(frameUpdated(GammaRay::RemoteViewFrame)), this,
             SLOT(frameUpdated(GammaRay::RemoteViewFrame)));
-    connect(m_interface, SIGNAL(requestClearFrameData()), this, SLOT(clearFrameData()));
     m_interface->clientViewUpdated();
 }
 
@@ -243,15 +242,6 @@ void RemoteViewWidget::frameUpdated(const RemoteViewFrame &frame)
     QMetaObject::invokeMethod(m_interface, "clientViewUpdated", Qt::QueuedConnection);
 }
 
-void RemoteViewWidget::clearFrameData()
-{
-    if (!m_frame.isValid())
-        return;
-    auto frame = m_frame;
-    frame.setData(QVariant());
-    frameUpdated(frame);
-}
-
 int RemoteViewWidget::invisibleMask() const
 {
     return m_invisibleMask;

ui/remoteviewwidget.h

@@ -193,7 +193,6 @@ private slots:
     void pickElementId(const QModelIndex &index);
     void elementsAtReceived(const GammaRay::ObjectIds &ids, int bestCandidate);
     void frameUpdated(const GammaRay::RemoteViewFrame &frame);
-    void clearFrameData();
 
 private:
     RemoteViewFrame m_frame;