Metaobjectbrowser #16

krf · 2012-07-13T08:41:08Z

New Meta Object Browser tool

Additions:

Meta Object Browser lists the hierarchy of meta objects
It's also possible to see meta object properties (enums, class info, etc.)
The probe now keeps a model of all (seen) meta objects
The property widget is capable of displaying either QObjects, Non-QObjects (e.g. QGrahpicsItem) and pure QMetaObjects
Tabs in the property widget are properly shown/hidden based on the object it holds
New manual stand-alone test executable for the property widget

vkrause · 2012-07-13T12:08:13Z

core/metaobjecttreemodel.cpp

+
+QVariant MetaObjectTreeModel::headerData(int section, Qt::Orientation orientation, int role) const
+{
+  if (role == Qt::DisplayRole) {


&& orientation == Qt::Horizontal, looks weird in a QTableView otherwise ;)

vkrause · 2012-07-13T12:29:33Z

Looks good in general, feel free to merge.

Properly fwd declare Ui_PropertyWidget in propertywidget.h, also, don't try to use the probe if it it isn't initialized.

Not QObject.

The property widget may now contain the following pointers: * QObject instance * Non-QObject instance, with meta type * QMetaObject instance Also: Don't enable/disable the tabs when they're unused, properly show/hide them

krf · 2012-07-13T16:42:17Z

Merged to master.
"Orientation fix" applied.
This need to investigate the meta object removal problem. Thats probably not that easy to track.

Fixes stack overflow when running plasmashell through gammaray: Thread 1 "plasmashell" received signal SIGSEGV, Segmentation fault. 0x00007ffff3ec51fc in ?? () from /usr/lib/libQt5Gui.so.5 (gdb) (gdb) bt #0 0x00007ffff3ec51fc in ?? () from /usr/lib/libQt5Gui.so.5 KDAB#1 0x00007ffff3eb4c16 in QImage::convertToFormat_helper(QImage::Format, QFlags<Qt::ImageConversionFlag>) const () from /usr/lib/libQt5Gui.so.5 KDAB#2 0x00007fffe6d8c185 in QXcbWindow::setWindowIcon(QIcon const&) () from /usr/lib/libQt5XcbQpa.so.5 KDAB#3 0x00007ffff3e75ef4 in QWindow::setIcon(QIcon const&) () from /usr/lib/libQt5Gui.so.5 KDAB#4 0x00007fffddae596a in GammaRay::GuiSupport::updateWindowIcon (this=0x55555577d8a0, w=0x555555aef4e0) at /home/milian/projects/src/gammaray/plugins/guisupport/guisupport.cpp:539 KDAB#5 0x00007fffddae5eff in GammaRay::GuiSupport::eventFilter (this=0x55555577d8a0, watched=0x555555aef4e0, event=0x7fffff801490) at /home/milian/projects/src/gammaray/plugins/guisupport/guisupport.cpp:594 KDAB#6 0x00007ffff23d40bf in GammaRay::Probe::eventFilter (this=0x555555705c00, receiver=0x555555aef4e0, event=0x7fffff801490) at /home/milian/projects/src/gammaray/core/probe.cpp:920 KDAB#7 0x00007ffff3446bdc in QCoreApplicationPrivate::sendThroughApplicationEventFilters(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5 KDAB#8 0x00007ffff462af6a in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5 KDAB#9 0x00007ffff4632a06 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5 KDAB#10 0x00007ffff3447060 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5 KDAB#11 0x00007ffff3e75f16 in QWindow::setIcon(QIcon const&) () from /usr/lib/libQt5Gui.so.5 KDAB#12 0x00007fffddae596a in GammaRay::GuiSupport::updateWindowIcon (this=0x55555577d8a0, w=0x555555aef4e0) at /home/milian/projects/src/gammaray/plugins/guisupport/guisupport.cpp:539 KDAB#13 0x00007fffddae5eff in GammaRay::GuiSupport::eventFilter (this=0x55555577d8a0, watched=0x555555aef4e0, event=0x7fffff801860) at /home/milian/projects/src/gammaray/plugins/guisupport/guisupport.cpp:594 KDAB#14 0x00007ffff23d40bf in GammaRay::Probe::eventFilter (this=0x555555705c00, receiver=0x555555aef4e0, event=0x7fffff801860) at /home/milian/projects/src/gammaray/core/probe.cpp:920 KDAB#15 0x00007ffff3446bdc in QCoreApplicationPrivate::sendThroughApplicationEventFilters(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5 KDAB#16 0x00007ffff462af6a in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5 KDAB#17 0x00007ffff4632a06 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5 KDAB#18 0x00007ffff3447060 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5 KDAB#19 0x00007ffff3e75f16 in QWindow::setIcon(QIcon const&) () from /usr/lib/libQt5Gui.so.5 KDAB#20 0x00007fffddae596a in GammaRay::GuiSupport::updateWindowIcon (this=0x55555577d8a0, w=0x555555aef4e0) at /home/milian/projects/src/gammaray/plugins/guisupport/guisupport.cpp:539 KDAB#21 0x00007fffddae5eff in GammaRay::GuiSupport::eventFilter (this=0x55555577d8a0, watched=0x555555aef4e0, event=0x7fffff801c30) at /home/milian/projects/src/gammaray/plugins/guisupport/guisupport.cpp:594 KDAB#22 0x00007ffff23d40bf in GammaRay::Probe::eventFilter (this=0x555555705c00, receiver=0x555555aef4e0, event=0x7fffff801c30) at /home/milian/projects/src/gammaray/core/probe.cpp:920

This patch fixes runtime attaching to an ASAN-enabled QiTissue. Previously I got the following crash reliably at startup: ``` ==352112==ERROR: AddressSanitizer: SEGV on unknown address 0x604016000459 (pc 0x7feb421bed63 bp 0x7ffdaed25490 sp 0x7ffdaed25478 T0) ==352112==The signal is caused by a READ memory access. #0 0x7feb421bed62 in QHashData::nextNode(QHashData::Node*) (/usr/lib/libQt5Core.so.5+0x104d62) KDAB#1 0x7fea9efc9932 in QHash<GammaRay::ToolFactory*, QHashDummyValue>::iterator::operator++() /usr/include/qt/QtCore/qhash.h:345 KDAB#2 0x7fea9efc8663 in QSet<GammaRay::ToolFactory*>::iterator::operator++() /usr/include/qt/QtCore/qset.h:129 KDAB#3 0x7fea9efc6e0c in GammaRay::ToolManager::objectAdded(QMetaObject const*) ../core/toolmanager.cpp:217 KDAB#4 0x7fea9efc6b67 in GammaRay::ToolManager::objectAdded(QObject*) ../core/toolmanager.cpp:194 KDAB#5 0x7fea9efa7b22 in GammaRay::Probe::objectFullyConstructed(QObject*) ../core/probe.cpp:688 KDAB#6 0x7fea9efa76b0 in GammaRay::Probe::objectAdded(QObject*, bool) ../core/probe.cpp:612 KDAB#7 0x7fea9efa8a30 in GammaRay::Probe::discoverObject(QObject*) ../core/probe.cpp:907 KDAB#8 0x7fea9efa8876 in GammaRay::Probe::findExistingObjects() ../core/probe.cpp:889 KDAB#9 0x7fea9efa6097 in GammaRay::Probe::createProbe(bool) ../core/probe.cpp:351 KDAB#10 0x7fead53fb5e7 in GammaRay::ProbeCreator::createProbe() ../probe/probecreator.cpp:92 KDAB#11 0x7fead53fae5f in GammaRay::ProbeCreator::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) probe/gammaray_probe_obj_autogen/EWIEGA46WW/moc_probecreator.cpp:72 KDAB#12 0x7feb4238cad9 in QObject::event(QEvent*) (/usr/lib/libQt5Core.so.5+0x2d2ad9) KDAB#13 0x7feb43294351 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib/libQt5Widgets.so.5+0x15b351) KDAB#14 0x7feb4329d828 in QApplication::notify(QObject*, QEvent*) (/usr/lib/libQt5Widgets.so.5+0x164828) KDAB#15 0x7feb4235f4f1 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (/usr/lib/libQt5Core.so.5+0x2a54f1) KDAB#16 0x7feb42361d55 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (/usr/lib/libQt5Core.so.5+0x2a7d55) KDAB#17 0x7feb423b8243 (/usr/lib/libQt5Core.so.5+0x2fe243) KDAB#18 0x7feb206da6bd in g_main_context_dispatch (/usr/lib/libglib-2.0.so.0+0x6b6bd) KDAB#19 0x7feb206dc530 (/usr/lib/libglib-2.0.so.0+0x6d530) KDAB#20 0x7feb206dc570 in g_main_context_iteration (/usr/lib/libglib-2.0.so.0+0x6d570) KDAB#21 0x7feb423b788f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (/usr/lib/libQt5Core.so.5+0x2fd88f) KDAB#22 0x7feb4235e05b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) (/usr/lib/libQt5Core.so.5+0x2a405b) KDAB#23 0x7feb42366065 in QCoreApplication::exec() (/usr/lib/libQt5Core.so.5+0x2ac065) KDAB#24 0x5643dbe05406 in main ../KDAB/qitissue/main.cpp:258 KDAB#25 0x7feb41269022 in __libc_start_main (/usr/lib/libc.so.6+0x27022) KDAB#26 0x5643dbdfd1ed in _start (/home/milian/projects/kdab/qitissue/build-asan/bin/QiTissue+0x6b1ed) ``` I can only explain this by assuming that the list got mutated while iterating over it, i.e. basically a recursion of `objectAdded` which could happen when we init the factory?

This patch fixes runtime attaching to an ASAN-enabled QiTissue. Previously I got the following crash reliably at startup: ``` ==352112==ERROR: AddressSanitizer: SEGV on unknown address 0x604016000459 (pc 0x7feb421bed63 bp 0x7ffdaed25490 sp 0x7ffdaed25478 T0) ==352112==The signal is caused by a READ memory access. #0 0x7feb421bed62 in QHashData::nextNode(QHashData::Node*) (/usr/lib/libQt5Core.so.5+0x104d62) #1 0x7fea9efc9932 in QHash<GammaRay::ToolFactory*, QHashDummyValue>::iterator::operator++() /usr/include/qt/QtCore/qhash.h:345 #2 0x7fea9efc8663 in QSet<GammaRay::ToolFactory*>::iterator::operator++() /usr/include/qt/QtCore/qset.h:129 #3 0x7fea9efc6e0c in GammaRay::ToolManager::objectAdded(QMetaObject const*) ../core/toolmanager.cpp:217 #4 0x7fea9efc6b67 in GammaRay::ToolManager::objectAdded(QObject*) ../core/toolmanager.cpp:194 #5 0x7fea9efa7b22 in GammaRay::Probe::objectFullyConstructed(QObject*) ../core/probe.cpp:688 #6 0x7fea9efa76b0 in GammaRay::Probe::objectAdded(QObject*, bool) ../core/probe.cpp:612 #7 0x7fea9efa8a30 in GammaRay::Probe::discoverObject(QObject*) ../core/probe.cpp:907 #8 0x7fea9efa8876 in GammaRay::Probe::findExistingObjects() ../core/probe.cpp:889 #9 0x7fea9efa6097 in GammaRay::Probe::createProbe(bool) ../core/probe.cpp:351 #10 0x7fead53fb5e7 in GammaRay::ProbeCreator::createProbe() ../probe/probecreator.cpp:92 #11 0x7fead53fae5f in GammaRay::ProbeCreator::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) probe/gammaray_probe_obj_autogen/EWIEGA46WW/moc_probecreator.cpp:72 #12 0x7feb4238cad9 in QObject::event(QEvent*) (/usr/lib/libQt5Core.so.5+0x2d2ad9) #13 0x7feb43294351 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (/usr/lib/libQt5Widgets.so.5+0x15b351) #14 0x7feb4329d828 in QApplication::notify(QObject*, QEvent*) (/usr/lib/libQt5Widgets.so.5+0x164828) #15 0x7feb4235f4f1 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (/usr/lib/libQt5Core.so.5+0x2a54f1) #16 0x7feb42361d55 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (/usr/lib/libQt5Core.so.5+0x2a7d55) #17 0x7feb423b8243 (/usr/lib/libQt5Core.so.5+0x2fe243) #18 0x7feb206da6bd in g_main_context_dispatch (/usr/lib/libglib-2.0.so.0+0x6b6bd) #19 0x7feb206dc530 (/usr/lib/libglib-2.0.so.0+0x6d530) #20 0x7feb206dc570 in g_main_context_iteration (/usr/lib/libglib-2.0.so.0+0x6d570) #21 0x7feb423b788f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (/usr/lib/libQt5Core.so.5+0x2fd88f) #22 0x7feb4235e05b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) (/usr/lib/libQt5Core.so.5+0x2a405b) #23 0x7feb42366065 in QCoreApplication::exec() (/usr/lib/libQt5Core.so.5+0x2ac065) #24 0x5643dbe05406 in main ../KDAB/qitissue/main.cpp:258 #25 0x7feb41269022 in __libc_start_main (/usr/lib/libc.so.6+0x27022) #26 0x5643dbdfd1ed in _start (/home/milian/projects/kdab/qitissue/build-asan/bin/QiTissue+0x6b1ed) ``` I can only explain this by assuming that the list got mutated while iterating over it, i.e. basically a recursion of `objectAdded` which could happen when we init the factory?

vkrause reviewed Jul 13, 2012
View reviewed changes

krf added 5 commits July 13, 2012 18:12

Add "Meta Object Browser" tool

9c3d9cc

Add PropertyWidgetTest

bdbcdac

Properly fwd declare Ui_PropertyWidget in propertywidget.h, also, don't try to use the probe if it it isn't initialized.

Depend on QMetaObject instance metaobjectmodel.h

5fe8ac4

Not QObject.

Make PropertyWidget three-state

1d4400f

The property widget may now contain the following pointers: * QObject instance * Non-QObject instance, with meta type * QMetaObject instance Also: Don't enable/disable the tabs when they're unused, properly show/hide them

Add the property widget to the meta object browser

c831f96

krf closed this Jul 13, 2012

AndriyP mentioned this pull request Sep 27, 2013

Crash during inspection GraphicsScene. #59

Open

davidedmundson mentioned this pull request Jul 2, 2014

Crash when trying to view scenegraph #84

Closed

tmcguire mentioned this pull request Dec 17, 2014

Crash when deleting QQuickItem after runtime attaching #104

Closed

aleixpol mentioned this pull request Jan 15, 2015

Crash when trying to run Akregator on GammaRay #108

Closed

milianw mentioned this pull request Apr 30, 2015

Selecting "GammaRay::OverlayWidget" in Widgets tree freezes GammaRay #109

Closed

allopislozano mentioned this pull request Oct 31, 2017

gammaray client crashes when trying to see signals and slots #469

Closed

milianw mentioned this pull request Nov 1, 2017

Prevent infinite recursion when tracing plasmashell with gammaray #470

Closed

hallarempt mentioned this pull request Sep 17, 2018

Crash in GammaRay::AggregatedPropertyModel::data #502

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Metaobjectbrowser #16

Metaobjectbrowser #16

krf commented Jul 13, 2012

vkrause Jul 13, 2012

vkrause commented Jul 13, 2012

krf commented Jul 13, 2012

Metaobjectbrowser #16

Metaobjectbrowser #16

Conversation

krf commented Jul 13, 2012

vkrause Jul 13, 2012

Choose a reason for hiding this comment

vkrause commented Jul 13, 2012

krf commented Jul 13, 2012