Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save zoomed state chart images #34

Merged
merged 2 commits into from
Oct 4, 2013

Conversation

syntheticpp
Copy link
Contributor

No description provided.

@milianw
Copy link
Member

milianw commented Sep 5, 2013

Hey there,

sorry I only see this now. With my recent refactoring this won't merge anymore. Could you please rebase against master? See StateMachineViewerWidget now for the places to do this.

Thanks!

@syntheticpp
Copy link
Contributor Author

I've rebased. And I didn't noticed your comment until today. Isn't there an email notification for stuff like this?

</widget>
</item>
<item>
<widget class="QLineEdit" name="limitEdit">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make it a spin box and allow fraction numbers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe not a fraction, but at least a spin box

@milianw
Copy link
Member

milianw commented Sep 23, 2013

Sorry, was on vacation. This looks good besides some small ui cleanup, then I'm ready for the pull!

Thanks!

@syntheticpp
Copy link
Contributor Author

Thanks for reviewing! I try to fix it this week.

The fixed scene size is to small to get a good image resolutions.
milianw added a commit that referenced this pull request Oct 4, 2013
@milianw milianw merged commit 5f20f94 into KDAB:master Oct 4, 2013
@milianw
Copy link
Member

milianw commented Oct 4, 2013

Thank you, I've merged it now and cleaned up the UI a bit more (at least, I think so). If you are interested, take a look at 661cbbd - bye!

@krf
Copy link
Contributor

krf commented Oct 4, 2013

Thanks for taking care of this. Slipped through my hands at some point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants