Move core/hooking to hooking/ #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hooking/ builds gammaray_probe which actually *uses* libgammaray_core from core/, so it doesn't make sense to keep it in a subdirectory
|
Note: This should fix the build on Windows. |
|
Makes sense, thanks! Feel free to merge after removing the remaining reference to hooking in core/CMakeLists.txt. Not sure it entirely fixes the Windows build though, we need to make ui/ (partially) a shared lib for that as well, I've some steps locally for that already, I'll try to complete it later today. |
|
Merged: commit ed7e1d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hooking/ builds gammaray_probe which actually uses libgammaray_core
from core/, so it doesn't make sense to keep it in a subdirectory