Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't build #333

Closed
yurivict opened this issue Jan 11, 2023 · 4 comments
Closed

Tests don't build #333

yurivict opened this issue Jan 11, 2023 · 4 comments

Comments

@yurivict
Copy link

With -DKDDockWidgets_TESTS=ON tests don't get built:

===>  Testing for kddockwidgets-1.6.0
-- Building KDDockWidgets 1.6.0 in Release mode. Installing to /usr/local
-- The following OPTIONAL packages have been found:

 * Qt5X11Extras

-- The following REQUIRED packages have been found:

 * Qt5Gui (required version >= 5.15.7)
 * Qt5Widgets
 * Qt5Test
 * Qt5 (required version >= 5.15)
 * Qt5Core

-- Configuring done
-- Generating done
-- Build files have been written to: /usr/ports/x11-toolkits/kddockwidgets/work/.build
ninja: no work to do.
[  0% 1/1] cd /usr/ports/x11-toolkits/kddockwidgets/work/.build && /usr/local/bin/ctest --force-new-ctest-process
Test project /usr/ports/x11-toolkits/kddockwidgets/work/.build
No tests were found!!!

Version: 1.6.0
Qt-5.15.7
FreeBSD 13.1

@winterz
Copy link
Member

winterz commented Jan 11, 2023

right, from the CMakeLists.txt file please see:

# -DKDDockWidgets_TESTS=[true|false] Build the test harness. Currently ignored
# (except for Python bindings) unless KDDockWidgets_DEVELOPER_MODE=True.
# Default=false

so you need to use -DKDDockWidgets_TESTS=ON -DKDDockWidgets_DEVELOPER_MODE=ON

@winterz winterz closed this as completed Jan 11, 2023
@iamsergio
Copy link
Contributor

Maybe we can remove that option, developer build always should imply tests. And our tests require developer build, so...

@winterz
Copy link
Member

winterz commented Jan 11, 2023

# -DKDDockWidgets_DEVELOPER_MODE=[true|false] Configure the build for a
# developer setup. Enables some features that are not geared towards end-users.
# Forces the test harness to be built. Default=false

so developer_mode already forces tests

we could add a warning:
"You are requesting testing without setting developer_mode. if you really want to enable the tests then you need to also enable developer_mode"

@iamsergio
Copy link
Contributor

I'm wondering, in which case would someone use -DKDDockWidgets_TESTS=ON

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants