-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add barcode support #22
Comments
I'm worried about KDReports ending up with 100 dependencies, if it's all implemented as shared libs to link to. Solution 1: providing the barcode as a QPixmap. But this leads to problems with printing high-definition, I think. |
Plugins could be a way. IMHO to be usefull reports must be user extensible, which means the barcode should also be available in the XML parser. On the other hand I guess there aren't that many possible elements one could wish in a report. There is already text, tables, and charts. Of the common elements only barcodes is missing. The tables could really see improvements with SUMs and grouping but that probably wouldn't be an external dependency. Is CI run internally or could it run from github actions? If it's run from github actions new dependency patches could require the CI changes as well. |
Sum and grouping sound like jobs for proxymodels anyway, those can be provided externally :) The CI is KDAB-internal at the moment, we'll handle it if necessary, no big deal. However solution 3 still sounds best to me? |
Using the same mechanism as KDChart It should be possible to add barcode support using KDE Framework's Prison library.
Would such patches be acceptable?
The text was updated successfully, but these errors were encountered: