Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-standand installation dirs #12

Closed
wants to merge 4 commits into from
Closed

Fix non-standand installation dirs #12

wants to merge 4 commits into from

Conversation

Petross404
Copy link
Contributor

As stated in here, Gentoo doesn't accept not standard installation dirs. If you would be so kind to accept this, I would be able to make an ebuild for KDStateMachineEditor and (later) Gammaray :)

@Petross404
Copy link
Contributor Author

One thing though : FULL variables aren't needed. ${CMAKE_INSTALL_BINDIR} would suffice.

@winterz
Copy link
Member

winterz commented Jan 28, 2018

looks good to me.
@krf please review and commit (or not) soon . I want to release this as part of KDSME 1.2.2 very soon.

@krf
Copy link
Contributor

krf commented Jan 29, 2018

@winterz Thanks for ping. Merged!

@krf
Copy link
Contributor

krf commented Jan 29, 2018

@Petross404 Just for future pull requests: Please make sure you've set a proper real name in Git; it's currently set to "Petross404".

https://help.github.com/articles/setting-your-username-in-git/

@Petross404
Copy link
Contributor Author

Thanks! Already changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants