Add struct size into tooltip

[azat]

No description provided.

[ogoffart]

Style issue: avoid C casts: prefer size_t(-1)

[azat]

On Fri, Jun 13, 2014 at 04:54:26AM -0700, Olivier Goffart wrote:

+{

• const clang::ASTContext &ctx = t->getASTContext();
• const clang::QualType &ty = ctx.getRecordType(t);
• return ctx.getTypeSize(ty);
  +}

+size_t getDeclSize(const clang::NamedDecl* decl)
+{

• const clang::CXXRecordDecl *cxx = llvm::dyn_castclang::CXXRecordDecl(decl);
• if (cxx && (cxx = cxx->getDefinition())) {

•    /**
  

•     \* XXX: avoid endless recursion inside
  

•     \* clang::ASTContext::getTypeInfo() -> getTypeInfoImpl()
  

•     */
  

•    if (cxx->isDependentContext()) {
  

•        return (size_t)-1;
  

Style issue: avoid C casts: prefer size_t(-1)

I follow the rule, that for POD-types it is okay to use C-style cast.
But no problem, I will fix this.

Thanks.

---

Reply to this email directly or view it on GitHub:
https://github.com/woboq/woboq_codebrowser/pull/12/files#r13747200

Respectfully
Azat Khuzhin

[ogoffart]

minor issue: should be on one line:

tags %= " data-size=" %  std::to_string(getDeclSize(decl));

Or even better: use llvm::Twine which reduce the number of string allocation.

But the number should be within quotes.

Also please check it is not -1

[ogoffart]

Thanks for the patch.

Maybe it is better to store the size in the refs file instead of everywhere in each .html. Don't you think?

[azat]

On Fri, Jun 13, 2014 at 05:07:24AM -0700, Olivier Goffart wrote:

Thanks for the patch.

Maybe it is better to store the size in the refs file instead of everywhere in each .html. Don't you think?

I don't have any objections, I will move it into refs shortly.
Thanks for comments.

---

Reply to this email directly or view it on GitHub:
#12 (comment)

Respectfully
Azat Khuzhin

[azat]

See add-struct-size-v2 branch.