Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo only example fails in main with Qt 5 due to std types confusion #592

Closed
ahayzen-kdab opened this issue Jun 26, 2023 · 2 comments · Fixed by #593
Closed

Cargo only example fails in main with Qt 5 due to std types confusion #592

ahayzen-kdab opened this issue Jun 26, 2023 · 2 comments · Fixed by #593
Labels
🪲 bug Something isn't working

Comments

@ahayzen-kdab
Copy link
Collaborator

ahayzen-kdab commented Jun 26, 2023 •
edited 

$ cargo run -p qml-minimal-no-cmake
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/debug/qml-minimal-no-cmake`
QQmlApplicationEngine failed to load component
qrc:/main.qml:26:17: Invalid property assignment: unsupported type ""

Using main the cargo-only build fails to run with Qt 5 due to std_types.cpp not occurring, it however works with CMake.

This is likely due to +whole-archive missing ?
@ahayzen-kdab ahayzen-kdab added the 🪲 bug Something isn't working label Jun 26, 2023
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 26, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
3672533 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Closes KDAB#592
This was referenced Jun 26, 2023
Merged
Open
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 26, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
3c931d0 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 26, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
723df93 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Closes KDAB#592
@Be-ing
Copy link
Contributor

Be-ing commented Jun 26, 2023

Oof, I hadn't noticed this because we default to using Qt6. I wonder when this bug was introduced?

@ahayzen-kdab
Copy link
Collaborator Author

Oof, I hadn't noticed this because we default to using Qt6. I wonder when this bug was introduced?

I assume it's from this 486b0a2

ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 26, 2023
@ahayzen-kdab
cxx-qt-build: move std_types from -lib into -build
9e988d7 
As this potentially allows us to have cxx-qt-lib separate in the future.

Related to KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 27, 2023
@ahayzen-kdab
cxx-qt-build: move std_types from -lib into -build
9ab2d59 
As this potentially allows us to have cxx-qt-lib separate in the future.

Related to KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 27, 2023
@ahayzen-kdab
cxx-qt-build: move std_types from -lib into -build
0da3c2e 
As this potentially allows us to have cxx-qt-lib separate in the future.

Related to KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 27, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
4c35044 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 27, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
41e809c 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 27, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
43b09bc 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
4ccada7 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
339b164 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
fca84bc 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
fbccc29 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
75cecee 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
81c0e8e 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 28, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
7df274b 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
ahayzen-kdab added a commit to ahayzen-kdab/cxx-qt that referenced this issue Jun 29, 2023
@ahayzen-kdab
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
482a421 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes KDAB#592
Be-ing pushed a commit that referenced this issue Jun 29, 2023
@ahayzen-kdab @Be-ing
cxx-qt-lib: use +whole_archive for std_types so that cargo-only works
b5e05c2 
When building with cargo we need to ensure that the statics aren't
optimised out for registering types with Qt 5.

Otherwise we cannot use numbers in QML.

Also move std_types from -lib into -build, which potentially allows
us to have cxx-qt-lib separate in the future.

Closes #592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cxx-qt-lib: use +whole_archive for std_types so that cargo-only works ahayzen-kdab/cxx-qt
2 participants
@Be-ing @ahayzen-kdab