New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: parse any #[property] attributes on struct fields #203

Merged

Be-ing merged 1 commit into KDAB:main from ahayzen-kdab:add-parse-properties

Aug 11, 2022

Collaborator

ahayzen-kdab commented Aug 10, 2022

Later when Data and RustObj structs are merged, properties will
be defined on the RustObj struct. This adds support for finding
these properties in the parser phase.

ahayzen-kdab force-pushed the add-parse-properties branch from 43b55f5 to bc56f89 Compare

August 10, 2022 17:48

Contributor

Be-ing commented Aug 10, 2022

How about renaming this to #[qproperty]? Simply #[property] could be misunderstood to be a Rust thing.

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/property.rs Outdated Show resolved Hide resolved

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/property.rs Show resolved Hide resolved

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/property.rs Show resolved Hide resolved

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/qobject.rs Show resolved Hide resolved

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/cxxqtdata.rs Outdated Show resolved Hide resolved

Be-ing reviewed

View reviewed changes

cxx-qt-gen/src/parser/cxxqtdata.rs Outdated Show resolved Hide resolved

Collaborator Author

ahayzen-kdab commented Aug 11, 2022

How about renaming this to #[qproperty]? Simply #[property] could be misunderstood to be a Rust thing.

I've been wondering the same with #[invokable] vs #[qinvokable] 🤔 Maybe we switch both to the latter.

Collaborator Author

ahayzen-kdab commented Aug 11, 2022

How about renaming this to #[qproperty]? Simply #[property] could be misunderstood to be a Rust thing.

I've been wondering the same with #[invokable] vs #[qinvokable] thinking Maybe we switch both to the latter.

Renamed to #[qproperty] I'll create a separate pull request to rename to #[qinvokable]


          cxx-qt-gen: parse any #[qproperty] attributes on struct fields

527d301

Later when Data and RustObj structs are merged, properties will
be defined on the RustObj struct. This adds support for finding
these properties in the parser phase.

ahayzen-kdab force-pushed the add-parse-properties branch from bc56f89 to 527d301 Compare

August 11, 2022 10:41

Collaborator Author

ahayzen-kdab commented Aug 11, 2022

Added a pull request to rename #[invokable] to #[qinvokable] #205

Be-ing approved these changes

View reviewed changes

Be-ing merged commit 5c05c21 into KDAB:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment