Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt-lib: add QRect support #51

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Conversation

ahayzen-kdab
Copy link
Collaborator

Related to #10

Change-Id: I9fcb9e5592b06d6282ef4bf162e12f871d381337

@ahayzen-kdab ahayzen-kdab mentioned this pull request Jan 7, 2022
14 tasks
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review January 7, 2022 14:10
@ahayzen-kdab ahayzen-kdab force-pushed the 10-add-qrect branch 3 times, most recently from a8037c0 to 8e1137f Compare January 19, 2022 18:50
@ahayzen-kdab ahayzen-kdab marked this pull request as draft January 19, 2022 18:51
@ahayzen-kdab
Copy link
Collaborator Author

Stacked on top of #47, will be marked as ready once that lands.

Related to KDAB#10

Change-Id: I9fcb9e5592b06d6282ef4bf162e12f871d381337
Related to KDAB#10

Change-Id: I92fc252671c2795998f452845a45615956141761
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review January 28, 2022 11:54
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add some explaining docs comments for some of the QRect weirdness.
Otherwise looks good.

cxx-qt-lib/src/qrect.rs Show resolved Hide resolved
Change-Id: I389fea97d038aea7dd15d3ec7af28ef51a9be4ea
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahayzen-kdab ahayzen-kdab merged commit 044bb03 into KDAB:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants