examples: use enum in list model #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to try out making a We should consider what QML support we want here. |
ahayzen-kdab
commented
Jul 28, 2023
Related to KDAB#34
ahayzen-kdab
force-pushed
the
34-qml-enums
branch
from
844d7a3
to
b93ab8f
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
commented
Jul 31, 2023
| @@ -158,6 +158,15 @@ pub mod qobject { | |||
| } | |||
| // ANCHOR_END: book_inherit_can_fetch_more_signature | |||
|
|
|||
| /// Roles for the QAbstractListModel | |||
| #[repr(i32)] | |||
| enum Roles { | |||
There was a problem hiding this comment.
As this is only used on the Rust side and not the C++/QML side, do we actually need to declare this as a shared enum ?
Or is this good to demo that they could cast the Roles::Id in C++ to an int and that would then work with the data method or if we could later expose that as a QML enum it would work ?
|
Closing in favour of #663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34