Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmakepreset 2 #707

Closed
wants to merge 4 commits into from
Closed

Add cmakepreset 2 #707

wants to merge 4 commits into from

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Oct 23, 2023

No description provided.

"cacheVariables": {
"CMAKE_BUILD_TYPE": "Release",
"BUILD_TESTING": "OFF",
"USE_QT5" : "ON"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you look at #498 and #498 there are a minefield of possible options and we were worried this file could become huge with so many options.

What do you think is the best way of covering the cases here ? And which ones should be left for CMakeUserPresets ? Eg i think probably sccache (from my old pull request) should be a user preset.

@@ -0,0 +1,145 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase this so that the merge commits are removed?

@OlivierLDff
Copy link
Contributor

I think the best would be to do like in corrosion: corrosion-rs/corrosion#443
The CMakePresets correspond to what is used in the CI. Then users have at least a base to create their own presets

@ahayzen-kdab
Copy link
Collaborator

I think the best would be to do like in corrosion: corrosion-rs/corrosion#443 The CMakePresets correspond to what is used in the CI. Then users have at least a base to create their own presets

Right, this is likely a good route, so then we'd have 6 ? options of Linux, macOS, Windows with Qt 5 and Qt 6 that CI can use the presets. Then devs can add user presets for any additional things and derive from the closest one.

@Montel Montel closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants