Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QPainter support #779

Merged
merged 29 commits into from
Jan 12, 2024
Merged

Add QPainter support #779

merged 29 commits into from
Jan 12, 2024

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Dec 28, 2023

No description provided.

@Montel Montel marked this pull request as ready for review December 29, 2023 10:15
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Montel , really nice change! QPainter is one of those APIs that we seem to need pretty often.

Only some smaller things left, then I'm happy to approve :)

crates/cxx-qt-lib/src/gui/qpainter.cpp Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/gui/qpainter.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib-headers/include/gui/qpainter.h Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/gui/mod.rs Outdated Show resolved Hide resolved
crates/cxx-qt-lib/src/gui/qpainter.rs Show resolved Hide resolved
crates/cxx-qt-lib/src/gui/qpainter.rs Show resolved Hide resolved
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny copy-pasta mistake in the documentation left.
Then we can merge 🥳

crates/cxx-qt-lib/src/gui/qpainter.rs Outdated Show resolved Hide resolved
Co-authored-by: Leon Matthes <leon.matthes@kdab.com>
@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (squash) January 12, 2024 10:14
@LeonMatthesKDAB LeonMatthesKDAB merged commit 7ceab98 into KDAB:main Jan 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants