-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEnum: Separate Structuring and use Name
struct.
#942
Merged
ahayzen-kdab
merged 4 commits into
KDAB:main
from
LeonMatthesKDAB:938-separate-structuring
Apr 24, 2024
Merged
QEnum: Separate Structuring and use Name
struct.
#942
ahayzen-kdab
merged 4 commits into
KDAB:main
from
LeonMatthesKDAB:938-separate-structuring
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
285eecd
to
26062ed
Compare
26062ed
to
ea0d4a5
Compare
This was referenced Apr 24, 2024
This should make it clearer what these are about, as this fits better with our current terminology.
Also use Name in the QEnum. Associate to the QObject in the later "structuring" phase.
ea0d4a5
to
bc4567e
Compare
ahayzen-kdab
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #938 and #939