Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use Name for C++ QObject generation #952

Merged
merged 1 commit into from
May 21, 2024
Merged

refactor: Use Name for C++ QObject generation #952

merged 1 commit into from
May 21, 2024

Conversation

LeonMatthesKDAB
Copy link
Collaborator

Part of #939

@LeonMatthesKDAB LeonMatthesKDAB mentioned this pull request May 17, 2024
Merged
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the 939-naming-module branch 2 times, most recently from f8219bb to d3c2065 Compare May 21, 2024 14:33
ahayzen-kdab
ahayzen-kdab approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM i think :-)

@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (rebase) May 21, 2024 15:00
@LeonMatthesKDAB LeonMatthesKDAB merged commit 584b7b5 into KDAB:main May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeonMatthesKDAB @ahayzen-kdab