build: fix deprecation warning when building appimage

This patch fixes the deprecation warnings when building the appimage.
It does this by using out kdesrc-build docker image as a building step
instead of running the whole build in the container. This allows us to
still build on centos7 but use the newer node20 actions.

.github/workflows/build-appimage.yml

@@ -20,27 +20,25 @@ jobs:
     if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
 
     runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/kdab/kdesrc-build
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
         submodules: recursive
 
     - name: Build
-      run: scripts/appimage/build_appimage.sh "$PWD" "$PWD/build"
+      uses: docker://ghcr.io/kdab/kdesrc-build:latest
 
     - name: Upload AppImage
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: appimage
-        path: /output/hotspot*.AppImage
+        path: ${{ github.workspace }}/*.AppImage
 
     - name: Upload Debug Info
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: debuginfo
-        path: /output/hotspot-debuginfo-*
+        path: ${{ github.workspace }}/hotspot-debuginfo-*

scripts/appimage/Dockerfile

@@ -128,4 +128,5 @@ RUN cd /opt && git clone --recursive https://github.com/KDAB/KDDockWidgets.git -
 FROM intermediate
 
 WORKDIR /
-RUN mkdir /output
+# set the entrypoint to the build script so that the build script will be run by github actions
+CMD ["/github/workspace/scripts/appimage/build_appimage.sh", "/github/workspace", "/github/workspace/build"]

scripts/appimage/build_appimage.sh

@@ -30,7 +30,7 @@ cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
 make -j$(nproc)
 DESTDIR=appdir make install
 
-tar -cjvf "/output/hotspot-debuginfo-$gitversion-x86_64.tar.bz2" \
+tar -cjvf "/github/workspace/hotspot-debuginfo-$gitversion-x86_64.tar.bz2" \
     --transform="s#appdir/#hotspot-debuginfo-$gitversion/#" \
     appdir/usr/bin/hotspot appdir/usr/lib64/libexec/hotspot-perfparser
 
@@ -74,4 +74,4 @@ linuxdeploy --appdir appdir --plugin qt \
     -d "./appdir/usr/share/applications/com.kdab.hotspot.desktop" \
     --output appimage
 
-mv Hotspot*x86_64.AppImage "/output/hotspot-$gitversion-x86_64.AppImage"
+mv Hotspot*x86_64.AppImage "/github/workspace/hotspot-$gitversion-x86_64.AppImage"

scripts/appimage/build_appimage_in_docker.sh

@@ -13,7 +13,6 @@ cd "$(dirname $0)"
 mkdir -p ../output/build-appimage
 
 docker run -it \
-    -v $PWD/../output:/output \
-    -v $PWD/../../:/hotspot \
+    -v $PWD/../../:/github/workspace/ \
     ghcr.io/kdab/kdesrc-build:latest \
-    /hotspot/scripts/appimage/build_appimage.sh /hotspot /output/build-appimage
+    /github/workspace/scripts/appimage/build_appimage.sh /github/workspace /github/workspace/build/build-appimage