Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dagmms singular problem #126

Merged
merged 1 commit into from
Jul 5, 2018
Merged

dagmms singular problem #126

merged 1 commit into from
Jul 5, 2018

Conversation

xasetl
Copy link
Member

@xasetl xasetl commented Jul 5, 2018

using inverse calculated by numpy to avoid torch's singular matrix problems

@xasetl xasetl requested a review from danthe96 July 5, 2018 18:49
danthe96
danthe96 approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@danthe96 danthe96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the performance impact is if we run DAGMM on a GPU... 😅 But doesn't matter for now

@xasetl xasetl merged commit 97cd18c into master Jul 5, 2018
@xasetl xasetl mentioned this pull request Jul 7, 2018
Closed
@xasetl xasetl deleted the dagmm_singular branch July 12, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danthe96 danthe96 danthe96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xasetl @danthe96