Skip to content

Commit

Permalink
ITIPHandler: emit correct signal in case of an error loading the cale…
Browse files Browse the repository at this point in the history
…ndar.

Summary:
This block is inside if (m_currentOperation == OperationProcessiTIPMessage)
so this is the signal that the caller (SyncItipHandler in kdepim-addons) expects.

Whether one faulty calendar item should lead to a complete calendar loading
failure, a messagebox when accepting an invitation, and a failure to insert
the invitation into the calendar, is another debate (and another fix surely),
but at least the event loop in SyncItipHandler finishes on error too.

Test Plan:
Clicking on an acceptation in kmail, with (apparently) invalid
kolab calendar items in shared folders.

Reviewers: smartins

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D5107
  • Loading branch information
dfaure committed Mar 19, 2017
1 parent 4a0c8a1 commit 1271161
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/itiphandler_p.cpp
Expand Up @@ -102,9 +102,9 @@ void ITIPHandler::Private::onLoadFinished(bool success, const QString &errorMess
m_queuedInvitation.iCal,
m_queuedInvitation.action);
} else {
emit q->iTipMessageSent(ResultError, i18n("Error loading calendar: %1", errorMessage));
emit q->iTipMessageProcessed(ResultError, i18n("Error loading calendar: %1", errorMessage));
}
} else if (m_currentOperation == OperationSendiTIPMessage) {
} else if (m_currentOperation == OperationSendiTIPMessage) {
q->sendiTIPMessage(m_queuedInvitation.method,
m_queuedInvitation.incidence,
m_parentWidget);
Expand Down

0 comments on commit 1271161

Please sign in to comment.