Allow files exported by LibreOffice to validate #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An apparent bug in the LibreOffice PPT exporter makes it output files
which technically don't conform to the PPT specification.
When loading a drawing each text paragraph in the drawing has a
TextPFRun structure ("A structure that specifies the paragraph-level
formatting of a run of text"). This starts with a mask, followed by a
sequence of fields. Only unmasked fields are included in the sequence.
According to Section 2.9.45 of the PPT specification version 6, the
following fields must be masked out:
masks.leftMargin
masks.indent
masks.defaultTabSize
masks.tabStops
In spite of this LibreOffice incorrectly includes the leftMargin and
indent fields (flags 0x100 and 0x400).
This patch loosens PPT requirements to allow files with these flags set
to pass validation.
|
Thanks for your contribution 😃 This repository is a mirror of a KDE repository. This means that developers are not looking at pull requests created in GitHub, so I'm closing this pull request (actually a bot is doing it). |
|
Same patch, now on Phabricator: https://phabricator.kde.org/D25259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An apparent bug in the LibreOffice PPT exporter makes it output files
which technically don't conform to the PPT specification.
When loading a drawing each text paragraph in the drawing has a
TextPFRun structure ("A structure that specifies the paragraph-level
formatting of a run of text"). This starts with a mask, followed by a
sequence of fields. Only unmasked fields are included in the sequence.
According to Section 2.9.45 of the PPT specification version 6, the
following fields must be masked out:
masks.leftMargin
masks.indent
masks.defaultTabSize
masks.tabStops
In spite of this LibreOffice incorrectly includes the leftMargin and
indent fields (flags 0x100 and 0x400).
This patch loosens PPT requirements to allow files with these flags set
to pass validation.
I've also created a Calligra patch to apply this change: https://phabricator.kde.org/D25256