Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two warnings and re-enable qt5 build on systems with modern cURL #21

Open
wants to merge 3 commits into
base: qt5-lts
Choose a base branch
from

Conversation

iyesin
Copy link

@iyesin iyesin commented Jun 12, 2024

Hello,

This small PR contains fixes for a problems I stepped into while trying to install craft on modern system with Qt5 as default framework.

@iyesin iyesin marked this pull request as ready for review June 12, 2024 15:38
@TheOneRing
Copy link
Contributor

Hi, all of them are already fixed on master.
So if you want to backport them I recomment to do that using "git cherrypick -x id".
In addition: This is a mirror of https://invent.kde.org/packaging/craft so I'd prefer it if you could open a pull request over there.

@iyesin
Copy link
Author

iyesin commented Jun 17, 2024

Hey @TheOneRing .
Nope, it does not fixed on master since the error is still present on LTS (Long Term Support) branch. I just tried it. The problem is still present here, on GitHub so I reported it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants