add unload all #7
Conversation
|
Thanks for your contribution 😃 This repository is a mirror of a KDE repository. This means that developers are not looking at pull requests created in GitHub, so I'm closing this pull request (actually a bot is doing it). |
|
I think this would make the already long tab context menu even bigger. PS: This is read-only mirror. |
| @@ -135,6 +136,9 @@ void TabContextMenu::init() | |||
| addAction(tr("Unload Tab"), this, SLOT(unloadTab())); | |||
| } | |||
|
|
|||
| addAction(tr("Unload All"), this, SLOT(unloadAllTabsInCurrentWindow())); | |||
| addAction(tr("Unload All (include Pinned)"), this, SLOT(unloadAllTabsInCurrentWindowWithPinned())); | |||
There was a problem hiding this comment.
This should be after the separator.
The separator separates the actions for CURRENT tab and ALL tabs
Please send the patch via KDE`s Phabricator as the bot told you.
| @@ -46,6 +46,7 @@ TabContextMenu::TabContextMenu(int index, BrowserWindow *window, Options options | |||
| connect(this, SIGNAL(detachTab(int)), tabWidget, SLOT(detachTab(int))); | |||
| connect(this, SIGNAL(loadTab(int)), tabWidget, SLOT(loadTab(int))); | |||
| connect(this, SIGNAL(unloadTab(int)), tabWidget, SLOT(unloadTab(int))); | |||
| connect(this, SIGNAL(unloadAllTabsInCurrentWindow(int, bool)), tabWidget, SLOT(unloadAllTabsInCurrentWindow(int,bool))); | |||
There was a problem hiding this comment.
Keep the space after the comma.
connect(this, SIGNAL(unloadAllTabsInCurrentWindow(int, bool)), tabWidget, SLOT(unloadAllTabsInCurrentWindow(int, bool)));
add unload all tabs in current window (include/exclude pinned) in tab context menu of tabwidget