Skip to content

Commit

Permalink
[KUrlCompletion] Don't append / to completed folders
Browse files Browse the repository at this point in the history
This is a quick fix to a usability issue.

Autosuggestions are made after / is appended to the folder name and pressing enter completes the autosuggetion. These 2 things are not wrong on their own, but they mess with people's heads when combined in this way. This change prevents the autosuggetion from being started when completing directories since it's only activated after the / is appended.

A better, but not so quick fix would be to make it so pressing enter only completes an autosuggestion after a character has been added after the /
  • Loading branch information
noahadvs committed Jul 14, 2020
1 parent 9cb68b5 commit 9f5f854
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/widgets/kurlcompletion.cpp
Expand Up @@ -576,7 +576,7 @@ void KUrlCompletionPrivate::init()
KConfigGroup cg(KSharedConfig::openConfig(), "URLCompletion");

url_auto_completion = cg.readEntry("alwaysAutoComplete", true);
popup_append_slash = cg.readEntry("popupAppendSlash", true);
popup_append_slash = cg.readEntry("popupAppendSlash", false);
onlyLocalProto = cg.readEntry("LocalProtocolsOnly", false);

q->setIgnoreCase(true);
Expand Down

0 comments on commit 9f5f854

Please sign in to comment.