-
-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clip character drawing to its own cell
Summary: To calculate string width, Konsole uses character cell widths. Rendering engine uses actual characters widths for this purpose. Those sizes are equal in fixed-width fonts, as long as the font has specific character. Since no font contains all Unicode characters, some of them are taken from different fonts and their sizes differ from their cell size. This can lead to different results depending on how text line is split into strings. It can be assumed that characters in Basic Latin block in every fixed-width font are really fixed-width, and can be rendered as one string. All other characters are rendered separately, and their rendering surface is limited to their cell. Before/After screenshots: {F5749612} BUG: 361547 Test Plan: Paste this: `⸻test` in konsole and highlight different parts of the string In a text editor paste this: ``` | A | | ⸻ | | ⟹ | | ⧠ | ``` and move cursor vertically through characters column Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: hindenburg, ngraham, #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D11237
- Loading branch information
1 parent
fb812c7
commit a565bc9
Showing
1 changed file
with
33 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters