Skip to content

Commit

Permalink
Revert "changed icons installation path"
Browse files Browse the repository at this point in the history
This reverts commit 8b8aa87.

Never ever have applications install own actions/status/etc icons
(i.e. anything different than the application own icon, and icons of
needed mimetypes) in the global icon theme, especially if hicolor.
Doing so:
- pollutes the global hicolor theme for *all* the installed application
- increases the risk for actual file conflicts (e.g. two applications
  trying to install the same action icon)
- allow the silent abuse of (private) icons installed with an
  application by other applications

For this reasons, own action icons of krusader should go better in the
private datadir of krusader, as hicolor; versions of those icons
provided by icon themes will override them anyway (and if they do not,
the Qt5 icon loading system is broken).

CCMAIL: davide@gengisdave.org
  • Loading branch information
Pino Toscano committed Aug 28, 2015
1 parent fb1748f commit 4b69dda
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pics/CMakeLists.txt
Expand Up @@ -39,7 +39,7 @@ ecm_install_icons(ICONS
32-actions-kr_split.png
32-actions-kr_unselect.png
32-actions-kr_unselectall.png
DESTINATION ${ICON_INSTALL_DIR}
DESTINATION ${DATA_INSTALL_DIR}/krusader/icons
THEME hicolor
)

2 changes: 1 addition & 1 deletion pics/kde3/CMakeLists.txt
Expand Up @@ -51,6 +51,6 @@ ecm_install_icons(ICONS
64-mimetypes-inode-fifo.png
64-mimetypes-tar.png
64-places-document-multiple.png
DESTINATION ${ICON_INSTALL_DIR}
DESTINATION ${DATA_INSTALL_DIR}/krusader/icons
THEME hicolor
)

0 comments on commit 4b69dda

Please sign in to comment.