Setting version of Kwave in the Cmake files #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps our releasing tools know which version we're packaging and do various things like set the released version on the appdata xml, create the bugzilla entry for that version, etc. This would help the give the appstream metadata.
|
Please note that the KDE project doesn't use github, which is just a mirror. More information on how to contribute are available here: https://community.kde.org/Get_Involved/development |
|
Hi! I have made the correct pull request on invent.kde.org and it got merged. Thanks for the reminder. I had forgotten to close to PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help give the app stream metadata. As these applications like Discover use this version as metadata for a listing of the application.
This is a fix proposed for the following bug pointed to on Bugzilla: https://bugs.kde.org/show_bug.cgi?id=425034
A similar change was also proposed to Kdenline for similar reasons, which can be seen here: KDE/kdenlive@50085b9