Skip to content

Commit

Permalink
Stop redirecting windows when item is disabled or hidden.
Browse files Browse the repository at this point in the history
Concretely fixes Task Manager tooltips slowing down app rendering even
after the tooltip is hidden.

REVIEW:126475
BUG:356938
  • Loading branch information
eikehein committed Dec 22, 2015
1 parent 9dcb6e5 commit c64a94a
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion src/declarativeimports/core/windowthumbnail.cpp
Expand Up @@ -98,6 +98,20 @@ WindowThumbnail::WindowThumbnail(QQuickItem *parent)
stopRedirecting();
startRedirecting();
});
connect(this, &QQuickItem::enabledChanged, [this]() {
if (!isEnabled()) {
stopRedirecting();
} else {
startRedirecting();
}
});
connect(this, &QQuickItem::visibleChanged, [this]() {
if (!isVisible()) {
stopRedirecting();
} else {
startRedirecting();
}
});
if (QGuiApplication *gui = dynamic_cast<QGuiApplication *>(QCoreApplication::instance())) {
m_xcb = (gui->platformName() == QStringLiteral("xcb"));
if (m_xcb) {
Expand Down Expand Up @@ -148,7 +162,11 @@ void WindowThumbnail::setWinId(uint32_t winId)
}
stopRedirecting();
m_winId = winId;
startRedirecting();

if (isEnabled() && isVisible()) {
startRedirecting();
}

emit winIdChanged();
}

Expand Down

0 comments on commit c64a94a

Please sign in to comment.