Skip to content

Commit

Permalink
Make includes more orderly
Browse files Browse the repository at this point in the history
1. header files
2. Qt
3. KDE

- alphabetically organized
- no spacing after copyright info
- one line of spacing after last include

NOTE: xcursor.cpp differs because it won't compile with a standardized ordering of includes.
  • Loading branch information
flipwise committed Jul 2, 2019
1 parent 3e3dbbb commit edaae61
Show file tree
Hide file tree
Showing 22 changed files with 70 additions and 101 deletions.
14 changes: 7 additions & 7 deletions sddmauthhelper.cpp
Expand Up @@ -17,20 +17,20 @@
*/
#include "sddmauthhelper.h"

#include <QDebug>
#include <QDir>
#include <QFile>
#include <QFileInfo>
#include <QDir>
#include <QSharedPointer>
#include <QDebug>
#include <QMimeType>
#include <QMimeDatabase>
#include <QMimeType>
#include <QSharedPointer>

#include <KLocalizedString>
#include <KZip>
#include <KTar>
#include <KArchive>
#include <KConfig>
#include <KConfigGroup>
#include <KLocalizedString>
#include <KTar>
#include <KZip>

static QSharedPointer<KConfig> openConfig(const QString &filePath)
{
Expand Down
11 changes: 5 additions & 6 deletions sddmthemeinstaller.cpp
Expand Up @@ -17,21 +17,20 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
*/

#include <QApplication>
#include <QCommandLineOption>
#include <QCommandLineParser>
#include <QDir>
#include <QFile>
#include <QDebug>
#include <QFile>
#include <QProcess>
#include <QCommandLineOption>
#include <QCommandLineParser>

#include <KLocalizedString>
#include <KAuthAction>
#include <KAuthExecuteJob>
#include <KConfigGroup>
#include <KLocalizedString>
#include <KMessageBox>
#include <KSharedConfig>
#include <KConfigGroup>

int main(int argc, char **argv)
{
Expand Down
15 changes: 7 additions & 8 deletions src/advanceconfig.cpp
Expand Up @@ -16,20 +16,19 @@
*/
#include "advanceconfig.h"
#include "ui_advanceconfig.h"
#include "config.h"
#include "cursortheme/thememodel.h"
#include "cursortheme/sortproxymodel.h"
#include "cursortheme/cursortheme.h"
#include "sessionmodel.h"
#include "usersmodel.h"

#include <QDebug>
#include <QIntValidator>

#include <QDebug>
#include <KConfigGroup>
#include <KUser>

#include "usersmodel.h"
#include "sessionmodel.h"
#include "config.h"
#include "cursortheme/thememodel.h"
#include "cursortheme/sortproxymodel.h"
#include "cursortheme/cursortheme.h"

const int MIN_UID = 1000;
const int MAX_UID = 60000;

Expand Down
6 changes: 2 additions & 4 deletions src/configwidgets/selectimagebutton.cpp
Expand Up @@ -18,15 +18,13 @@
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/

#include "selectimagebutton.h"

#include <QWidgetAction>

#include <QUrl>
#include <QFileDialog>
#include <QImageReader>
#include <QMenu>
#include <QUrl>
#include <QWidgetAction>

#include <KLocalizedString>
#include <KMessageBox>
Expand Down
11 changes: 4 additions & 7 deletions src/cursortheme/cursortheme.cpp
Expand Up @@ -16,24 +16,21 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/
#include "cursortheme.h"
// #include <config-X11.h>

#include <QApplication>
#include <QStyle>
#include <QCursor>
#include <QImage>
#include <QFile>
#include <QImage>
#include <QStyle>
#include <QX11Info>

#include "cursortheme.h"

// #include <config-X11.h>

#ifdef HAVE_XFIXES
# include <X11/Xlib.h>
# include <X11/extensions/Xfixes.h>
#endif


CursorTheme::CursorTheme(const QString &title, const QString &description)
{
setTitle(title);
Expand Down
3 changes: 1 addition & 2 deletions src/cursortheme/cursortheme.h
Expand Up @@ -16,12 +16,11 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/

#ifndef CURSORTHEME_H
#define CURSORTHEME_H

#include <QPixmap>
#include <QHash>
#include <QPixmap>

/**
* This is the abstract base class for all cursor themes stored in a
Expand Down
3 changes: 1 addition & 2 deletions src/cursortheme/dummytheme.cpp
Expand Up @@ -14,11 +14,10 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "dummytheme.h"

#include <QImage>
#include <QCursor>
#include <QImage>

#include <KLocalizedString>

Expand Down
5 changes: 2 additions & 3 deletions src/cursortheme/sortproxymodel.cpp
Expand Up @@ -16,11 +16,10 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/

#include <QString>
#include "sortproxymodel.h"
#include "cursortheme.h"
#include "sortproxymodel.h"

#include <QString>

int SortProxyModel::compare(const QModelIndex &left, const QModelIndex &right, int role) const
{
Expand Down
4 changes: 2 additions & 2 deletions src/cursortheme/sortproxymodel.h
Expand Up @@ -16,13 +16,13 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/

#ifndef SORTPROXYMODEL_H
#define SORTPROXYMODEL_H

#include <QSortFilterProxyModel>
#include "thememodel.h"

#include <QSortFilterProxyModel>

/**
* SortProxyModel is a sorting proxy model intended to be used in combination
* with the ItemDelegate class.
Expand Down
15 changes: 6 additions & 9 deletions src/cursortheme/thememodel.cpp
Expand Up @@ -15,17 +15,16 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/
#include "thememodel.h"
#include "xcursortheme.h"


#include <KLocalizedString>
#include <KConfig>
#include <KConfigGroup>
#include <QStringList>
#include <QDir>
#include <QStringList>
#include <QX11Info>

#include "thememodel.h"
#include "xcursortheme.h"
#include <KConfig>
#include <KConfigGroup>
#include <KLocalizedString>

#include <X11/Xlib.h>
#include <X11/Xcursor/Xcursor.h>
Expand All @@ -36,8 +35,6 @@
# define XCURSOR_LIB_MINOR XCURSOR_MINOR
#endif



CursorThemeModel::CursorThemeModel(QObject *parent)
: QAbstractTableModel(parent)
{
Expand Down
1 change: 0 additions & 1 deletion src/cursortheme/thememodel.h
Expand Up @@ -16,7 +16,6 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/

#ifndef THEMEMODEL_H
#define THEMEMODEL_H

Expand Down
13 changes: 6 additions & 7 deletions src/cursortheme/xcursortheme.cpp
Expand Up @@ -16,22 +16,21 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/
#include <QCursor>
#include <QDir>
#include <QImage>
#include <QTextStream>
#include <QX11Info>

#include <KLocalizedString>
#include <KConfig>
#include <KConfigGroup>
#include <KLocalizedString>

#include <QCursor>
#include <QImage>
#include <QDir>
#include <QX11Info>
#include <QTextStream>
#include <X11/Xlib.h>
#include <X11/Xcursor/Xcursor.h>

#include "xcursortheme.h"


// Static variable holding alternative names for some cursors
QHash<QString, QString> XCursorTheme::alternatives;

Expand Down
5 changes: 2 additions & 3 deletions src/cursortheme/xcursortheme.h
Expand Up @@ -16,14 +16,13 @@
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/

#ifndef XCURSORTHEME_H
#define XCURSORTHEME_H

#include <QHash>

#include "cursortheme.h"

#include <QHash>

class QDir;

struct _XcursorImage;
Expand Down
19 changes: 7 additions & 12 deletions src/sddmkcm.cpp
Expand Up @@ -14,30 +14,25 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "advanceconfig.h"
#include "config.h"
#include "sddmkcm.h"
#include "themeconfig.h"

#include <algorithm>

#include <QDebug>
#include <QDir>
#include <QHBoxLayout>
#include <QTabWidget>

#include <KPluginFactory>

#include <KAuth/KAuthActionReply>

#include <KAboutData>

#include <KAuth/KAuthActionReply>
#include <kauthexecutejob.h>
#include <KLocalizedString>
#include <QDebug>

#include "config.h"
#include "themeconfig.h"
#include "advanceconfig.h"

#include <KPluginFactory>
#include <kpluginfactory.h>
#include <kpluginloader.h>
#include <kauthexecutejob.h>

K_PLUGIN_FACTORY(SddmKcmFactory, registerPlugin<SddmKcm>();)

Expand Down
6 changes: 2 additions & 4 deletions src/sessionmodel.cpp
Expand Up @@ -16,20 +16,18 @@
* Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
***************************************************************************/

#include "config.h"
#include "sessionmodel.h"

#include <memory>

#include <QDir>
#include <QFile>
#include <QList>
#include <QTextStream>

#include <memory>

#include <KLocalizedString>


class Session {
public:
QString file;
Expand Down
2 changes: 0 additions & 2 deletions src/sessionmodel.h
Expand Up @@ -16,12 +16,10 @@
* Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
***************************************************************************/

#ifndef SDDM_SESSIONMODEL_H
#define SDDM_SESSIONMODEL_H

#include <QAbstractListModel>

#include <QHash>

class SessionModelPrivate;
Expand Down
15 changes: 7 additions & 8 deletions src/themeconfig.cpp
Expand Up @@ -14,28 +14,27 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "config.h"
#include "themeconfig.h"
#include "ui_themeconfig.h"
#include "themesmodel.h"
#include "themesdelegate.h"

#include <QDebug>
#include <QFile>
#include <QFileDialog>
#include <QPointer>
#include <QQuickView>
#include <QQuickItem>
#include <QQmlContext>
#include <QDebug>
#include <QStandardPaths>
#include <QPointer>
#include <QFileDialog>

#include <KMessageBox>
#include <KConfigGroup>
#include <KNewStuff3/KNS3/DownloadDialog>
#include <KAuthAction>
#include <KAuthActionReply>
#include <KAuthExecuteJob>

#include "config.h"
#include <KConfigGroup>
#include <KMessageBox>
#include <KNewStuff3/KNS3/DownloadDialog>

ThemeConfig::ThemeConfig(const KSharedConfigPtr &config, QWidget *parent) :
QWidget(parent),
Expand Down
2 changes: 1 addition & 1 deletion src/thememetadata.cpp
Expand Up @@ -20,8 +20,8 @@
#include <QSharedData>
#include <QSharedPointer>

#include <KDesktopFile>
#include <KConfigGroup>
#include <KDesktopFile>

class ThemeMetadataPrivate : public QSharedData
{
Expand Down

0 comments on commit edaae61

Please sign in to comment.