New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to publish a list of repos to a prefix #11
Conversation
Allow publishing a list of repositories with different components to a single prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks. Otherwise LGTM
lib/aptly/publish.rb
Outdated
@@ -42,6 +42,16 @@ def list(connection = Connection.new, **kwords) | |||
query: kwords) | |||
JSON.parse(response.body).collect { |h| new(connection, h) } | |||
end | |||
|
|||
# Publish a [Array<PublishedRepository>] list of repositories to a prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array<Repository>
test/integration.rb
Outdated
assert_equal %w[amd64], pub.Architectures | ||
assert_equal %w[kitten puppy] , pub.Sources.collect(&:Name).sort | ||
assert pub.Sources[0].is_a? ::Aptly::Repository | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth it to assert the final component. Same for the unit test.
Fixed nitpicks |
Allow publishing a list of repositories with different components
to a single prefix