Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ShowScopeMembersOnly representation to UserReferenceProperty #1419

Merged
merged 3 commits into from
May 8, 2024
Merged

Add ShowScopeMembersOnly representation to UserReferenceProperty #1419

merged 3 commits into from
May 8, 2024

Conversation

raduiordache
Copy link
Collaborator

@raduiordache raduiordache commented May 8, 2024 •
edited

Updated tests, enums, and models to support the 'ShowScopeMembersOnly' representation for 'UserReferenceProperty'. Added new class 'ScopeMembersOnlyRepresentation' and related tests. Updated changelog to reflect these changes.

Fixes #

Checklist:

  • My code follows the pykechain style
    • I added type hinting to all functions
    • I added documentation for all public functions
    • I locally used tox to check for dists and docs errors
    • My code passes the pep8 and flake8 linting checks and no warnings
    • I removed unused imports, using Code > Optimize Imports in PyCharm
    • I used black to format the new code
  • I have added tests that prove my fix is effective or that my feature works
    • I committed fresh test cassettes
    • I have proper test coverage (don't decline the coverage of the test)
  • I asked another teammate to review the code
  • I update the Changelog.md with the appropriate changes.

@raduiordache
Add ShowScopeMembersOnly representation to UserReferenceProperty
2d25cc9 
Updated tests, enums, and models to support the 'ShowScopeMembersOnly' representation for 'UserReferenceProperty'. Added new class 'ScopeMembersOnlyRepresentation' and related tests. Updated changelog to reflect these changes.
@raduiordache raduiordache requested a review from jberends May 8, 2024 11:56
@raduiordache raduiordache self-assigned this May 8, 2024
@raduiordache raduiordache linked an issue May 8, 2024 that may be closed by this pull request
Add 'show only scope members' representation on the UserReferenceProperty #1418
Closed
@raduiordache
Add cassette files for testing 'ScopeMembersOnlyRepresentation' funct…
c1e5b0b 
…ionality

These cassette files have been added to test various aspects of the 'ScopeMembersOnlyRepresentation' functionality. This test range comprises - retrieving, setting, and updating values as well as verification for 'Not Found' responses.
@raduiordache
Merge branch 'refs/heads/main' into 1418-add-show-only-scope-members-…
46165ee 
…representation-on-the-userreferenceproperty
jberends
jberends approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@jberends jberends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one - no problem that i see

@raduiordache raduiordache merged commit 4cb42f6 into main May 8, 2024
9 checks passed
@raduiordache raduiordache deleted the 1418-add-show-only-scope-members-representation-on-the-userreferenceproperty branch May 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberends jberends jberends approved these changes

Assignees

@raduiordache raduiordache

Labels
enhancement testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'show only scope members' representation on the UserReferenceProperty
2 participants
@raduiordache @jberends