Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker Desktop check + context #75

Merged
merged 1 commit into from Nov 12, 2019
Merged

Fix Docker Desktop check + context #75

merged 1 commit into from Nov 12, 2019

Conversation

jfri3d
Copy link
Collaborator

@jfri3d jfri3d commented Nov 11, 2019

Description

Closes #74.

  • added check for whether docker is running
  • added check for correct context

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the kaos contribution guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@jfri3d jfri3d requested a review from nithishr November 11, 2019 17:06
@jfri3d jfri3d added the bug Something isn't working label Nov 11, 2019
@jfri3d jfri3d added this to In progress in kaos via automation Nov 11, 2019
@jfri3d jfri3d changed the title #74: docker desktop check + context Fix Docker Desktop check + context Nov 11, 2019
WiktorJ
WiktorJ suggested changes Nov 12, 2019
View reviewed changes
cli/kaos_cli/utils/decorators.py Outdated Show resolved Hide resolved
@jfri3d
#74: docker desktop check + context
1fc4509 
- added check for whether docker is running
- added check for correct context
- added check for different docker contexts
nithishr
nithishr approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@nithishr nithishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WiktorJ WiktorJ merged commit dd4eed1 into master Nov 12, 2019
kaos automation moved this from In progress to Done Nov 12, 2019
@WiktorJ WiktorJ deleted the #74_local_docker_fix branch November 12, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiktorJ WiktorJ WiktorJ approved these changes

@nithishr nithishr nithishr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
kaos
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker desktop context check not included when building DOCKER
3 participants
@jfri3d @WiktorJ @nithishr