Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K-82: General refactor and CLI unit tests #90

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

K-82: General refactor and CLI unit tests #90

wants to merge 15 commits into from

Conversation

ms-shankar
Copy link
Contributor

Description

Closes issue #82

Checklist

  • An issue was first created before opening this pull request
  • The new code follows the kaos contribution guidelines
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to ensure that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ms-shankar ms-shankar self-assigned this Nov 26, 2019
@ms-shankar ms-shankar changed the title [WIP]K-82: General refactor and Cli unit tests K-82: General refactor and CLI unit tests Jan 24, 2020
@ms-shankar ms-shankar marked this pull request as ready for review January 24, 2020 09:41
aalhour
aalhour suggested changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need refactoring, there is a lot of state management and conditional logic that will make a test pass or fail based on the state mutations within the test cases.

cli/kaos_cli/facades/tests/test_backend_facade.py Show resolved Hide resolved
cli/kaos_cli/facades/tests/test_backend_facade.py Show resolved Hide resolved
cli/kaos_cli/facades/tests/test_backend_facade.py Outdated Show resolved Hide resolved
cli/kaos_cli/facades/tests/test_backend_facade.py Outdated Show resolved Hide resolved
cli/kaos_cli/services/tests/test_state_service.py Show resolved Hide resolved
cli/kaos_cli/facades/tests/test_backend_facade.py Outdated Show resolved Hide resolved
cli/kaos_cli/services/tests/test_state_service.py Outdated Show resolved Hide resolved
cli/kaos_cli/services/tests/test_tf_service.py Show resolved Hide resolved
cli/kaos_cli/services/tests/test_state_service.py Outdated Show resolved Hide resolved
cli/kaos_cli/services/tests/test_state_service.py Outdated Show resolved Hide resolved
aalhour
aalhour suggested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side-effects and managed state at the level of the test case are still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalhour aalhour aalhour requested changes

@jfri3d jfri3d Awaiting requested review from jfri3d

@ImScientist ImScientist Awaiting requested review from ImScientist

At least 1 approving review is required to merge this pull request.

Assignees

@ms-shankar ms-shankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ms-shankar @aalhour