Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rococo protocol id #369

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: rococo protocol id #369

merged 1 commit into from
Jun 13, 2022

Conversation

ggera
Copy link
Member

@ggera ggera commented Jun 13, 2022 •
edited

NO TICKET

Checklist:

We should have downloaded via wget with init container yet for now Check line 21 : https://paritytech.github.io/chainspecs/rococo/relaychain/chainspec.json

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@ggera ggera requested a review from wischli June 13, 2022 13:53
@ggera ggera self-assigned this Jun 13, 2022
wischli
wischli approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wischli wischli merged commit 2694263 into develop Jun 13, 2022
@wischli wischli deleted the rename-rococo-id branch June 13, 2022 19:15
ntn-x2 pushed a commit that referenced this pull request Jun 23, 2022
@ggera @ntn-x2
fix: rococo protocol id (#369)
bce3121 
(cherry picked from commit 2694263)
ntn-x2 added a commit that referenced this pull request Jun 24, 2022
@ntn-x2
feat: release 1.7.0 (#373)
aa39f8d 
* Adds two more relaychain bootnodes for staging environment  (#334)

* chore: reset peregrine stg (#335)

* ci: use custom ci image (#336)

* Optimizes docker layer (#337)

* fix: add did lookup pallet to DID authorization logic + reverse lookup index (#343)

* chore: update toolchain version to nightly 1.59 (#339)

* feat: proxy type for disableling deposit claiming (#341)

* fix: rococo protocol id (#369)

* feat: generic access control (#316)

* Updates toolchain version (#345)

* refactor: enforce no runtime in pallet (#349)

* fix: features (#353)

* feat: add tips pallet (#352)

* feat: upgrade to Polkadot v0.9.19 (#357)

* chore: upgrade and clean up (#360)

* Adds the new rococo chainspec (#363)

* feat: add launch pallet removal migration (#359)

* refactor: update rilt para id from 2015 to 2108 (#364)

* fix: rilt para id (#365)

* feat: upgrade to Polkadot v0.9.23 (#366)

* use ci-linx:production base image (#368)

* feat: upgrade to Polkadot v0.9.24 (#370)

* fix: fix CI builders compilation errors and pin to a specific hash (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

Assignees

@ggera ggera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggera @wischli