Resolution refactoring #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing override in LikelihoodBase class
Crystal ball transfer functions
Fixing compilation warning
Using constexp to speed up computation
Optimization
Extending supported eta range for jets to 4.5
|
@TomasDado, can this PR be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the Resolution classes
Description
Moved resolution definition and implementation to separate folders. Now classes properly inherit if it makes sense.
Related Issue
#87
How Has This Been Tested?
Code can compile.
BUT THE PARAMETER READING IS BROKEN - LOGIC NEEDS TO APPLIED DIFFERENTLY
Checklist: