Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to have Show parameter names on by default #1228

Closed
nikosavola opened this issue Dec 21, 2022 · 2 comments
Closed

Add option to have Show parameter names on by default #1228

nikosavola opened this issue Dec 21, 2022 · 2 comments
Assignees
@klayoutmatthias
Labels
enhancement
Milestone
0.28.3

Comments

@nikosavola
Copy link
Contributor

The Show parameter names is something very useful I didn't think I would need. I would prefer to have it always on, so I suggest adding an option somewhere in Setup to have it on by default. The default behaviour for this should still stay as it is now, i.e., the parameter names are not shown.
@nikosavola nikosavola mentioned this issue Dec 21, 2022
Closed
klayoutmatthias added a commit that referenced this issue Dec 25, 2022
@klayoutmatthias
Implemented solution for issue #1228
50616ed 
The "show parameter names" setting is now persisted.
Side effect: changing this setting will now trigger
a configuration update which has some side effects - e.g.
when "lazy update" is configured (parameters are reset).
But that appears to be acceptable.

In addition a second flaw was fixed: errors were not
properly reported by showing the error indicator.
The indicator was hidden immediately after showing it.
@klayoutmatthias klayoutmatthias added this to the 0.28.3 milestone Dec 25, 2022
@klayoutmatthias klayoutmatthias self-assigned this Dec 25, 2022
@klayoutmatthias
Copy link
Collaborator

I can make this parameter persistent, so you don't need to set it every time you start KLayout. This is easier than some additional configuration parameter.

@nikosavola
Copy link
Contributor Author

I can make this parameter persistent, so you don't need to set it every time you start KLayout. This is easier than some additional configuration parameter.

This seems like a good solution. This issue can be closed after merging #1231.

klayoutmatthias added a commit that referenced this issue Dec 27, 2022
@klayoutmatthias
Merge pull request #1231 from KLayout/issue-1228
975a752 
Implemented solution for issue #1228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
enhancement
Projects
None yet
Milestone
0.28.3
Development

Successfully merging a pull request may close this issue.

Add option to enable 'Show parameter names' by default nikosavola/klayout
2 participants
@nikosavola @klayoutmatthias