Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete fill #1309

Closed
klayoutmatthias opened this issue Mar 2, 2023 · 0 comments
Closed

Incomplete fill #1309

klayoutmatthias opened this issue Mar 2, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Mar 2, 2023

This ticket originates from this discussion (rear part): https://www.klayout.de/forum/discussion/2162/automating-the-untilities-fill-tool-in-ruby#latest

Test data is attached. The script which generates the fill is this:

to_fill = input(1, 0)
# Create a fill pattern with a 0.025x0.025 µm box at 2/0
pattern = fill_pattern("FILL_CELL").shape(2, 0, box(0, 0, 0.025, 0.025))
pattern.origin(0.0125, 0.0125)

# place every 25 nm
to_fill.fill(pattern, hstep(0.025), vstep(0.025))

# find gaps
input(2, 0).merged.space(0.05.um).output(100,0)

Fill test.zip

The expectation is to see a fully filled ring. Instead gaps appear.

The issue can be reproduced by a simple version of the test case:

discussion_2162.oas.zip

Side note: using "deep" mode will not perform the space check as the generated 2/0 layer is not read correctly as "input(2, 0)".

klayoutmatthias pushed a commit that referenced this issue Mar 4, 2023
Fixed polygon rasterizer.
Reason was the clip edge function that delivered
vertical edges from skew ones due to rounding.
These must not be skipped when exactly on a pixel
boundary as true vertical edges are.
@klayoutmatthias klayoutmatthias self-assigned this Mar 4, 2023
@klayoutmatthias klayoutmatthias added this to the 0.28.6 milestone Mar 4, 2023
klayoutmatthias added a commit that referenced this issue Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant