Issue 1189 High memory footprint for DRC deck #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was that destruction of database objects was postponed during callbacks, specifically the interpreter callback. This caused db::Region objects to pile up. The original feature was introduced to prevent issues when Ruby/C++ code interacts inside Qt UIs. The new fix does not disable GC, but protects Ruby objects during method calls. Maybe that solves the problem too.
…nodes got deleted.
… after GC became active. Added a documentation hint.
… DRC tests for heavy GC load testing
klayoutmatthias
force-pushed
the
issue-1189
branch
from
40b7e6e
to
53d6e8d
Compare
|
Thanks, this is working well for me locally. I'm wondering if it would be possible to get a release with this fix in too? |
|
Yes, there is. I will release an additional 0.27.13 without that fix (stable branch - some important hot patches) and then 0.28 (target is in two weeks) with this fix. Best regards, Matthias |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.