Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refactor CgSwap #789

Open
xs5871 opened this issue May 12, 2023 · 2 comments
Open

[Enhancement] Refactor CgSwap #789

xs5871 opened this issue May 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@xs5871
Copy link
Collaborator

xs5871 commented May 12, 2023

Continuation of #768.

The current CgSwap module is a bit of mess concerning code quality and the current implementation doesn't easily allow for multiple mod- (or even potentially any key-) swaps.
Suggestion: Refactor and handle any key (or at least any mod) swap.
@xs5871 xs5871 added the enhancement New feature or request label May 12, 2023
@dunk2k
Copy link
Contributor

dunk2k commented May 14, 2023 •
edited

@xs5871
Would this ModSwap or KeySwap module come with preset classes?
I.e. AltGuiSwap, BackSwap (Backslash, Backspace)

@xs5871
Copy link
Collaborator Author

xs5871 commented May 25, 2023

Ideally no, it would be simple enough that presets aren't needed. If you can pass a list of tuples to be switched + a mechanism to select them (similar to layers), then there's no need to have a class for every combination of keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xs5871 @dunk2k