Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reviung default coords mappings seems wrong #945

Open
bvelado opened this issue Mar 11, 2024 · 0 comments
Open

[BUG] Reviung default coords mappings seems wrong #945

bvelado opened this issue Mar 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@bvelado
Copy link

bvelado commented Mar 11, 2024

Decription

Using a fresh clone of this repository, I uploaded both kb.py and main.py from boards/gtips/reviung41 on my keyboard, a reviung41 using a boardsource blok controller.

I found out that coord_mapping were not consistent with key mappings in main.py, and also not consistent with the way they were organised to match the actual keyboard shape.

I tried to change it by mapping rows for the left part first, then for the right part and finally for the bottom row, which worked perfectly (w/o changing main.py).

TLDR: Rows in default coord_mapping are mapped as if they were wired for a 3X12 keyboard, while they are actually wired on the keyboard like a split 3X6, starting left hand then right hand.

See https://reviung.com/wp-content/uploads/2020/01/reviung41-pcb-2.jpg

To Reproduce

Steps to reproduce the behavior:

  1. Copy boards/gtips/reviung41 files on your CircuitPython micro controller, powering a rev1.2 Reviung41 PCB

Expected behavior

Default mapping should match what is defined in main.py (alphas for exemple should match a qwerty alphas layout)

Solution (that worked in my case)

In order to have main.py mappings match the actual keyboard layout, I changed coord_mapping to

    coord_mapping = [
              0,  1,  2,  3,  4,  5,    18, 19, 20, 21, 22, 23,
            6,  7,  8,  9, 10, 11,        24, 25, 26, 27, 28, 29,
          12, 13, 14, 15, 16, 17,           30, 31, 32, 33, 34, 35,
                         36,   37,  38,  39,   40,  
    ]

Additional context

I am pretty new to custom keyboards, and even newer to KMK so please be kind, I tried to understand what could have gone wrong before opening this issue!

@bvelado bvelado added the bug Something isn't working label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant