Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161660074 Refactor Code to Improve During Consuming #22

Merged
merged 5 commits into from
Nov 1, 2018

Conversation

KMaina
Copy link
Owner

@KMaina KMaina commented Nov 1, 2018

What does this PR do?

Improve the API to enhance the user experience

Description of Task to be completed?

Have more descriptive error codes

How should this be manually tested?

  • Clone the repo locally
  • Create virtual environment and run pytest
  • In Postman supply invalid values and have the key of those error messages being error
  • In Postman supply valid values and have the key of those success messages being success

Any background context you want to provide?

None

What are the relevant pivotal tracker stories?

#161660074

@KMaina KMaina merged commit 2689e97 into develop Nov 1, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 129

  • 17 of 39 (43.59%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/api/v2/resource/models/model_users.py 5 11 45.45%
app/api/v2/resource/models/model_sales.py 4 11 36.36%
app/api/v2/resource/models/model_products.py 8 17 47.06%
Totals Coverage Status
Change from base Build 125: 0.1%
Covered Lines: 1099
Relevant Lines: 1228

💛 - Coveralls

@KMaina KMaina deleted the ch-improve-api-161660074 branch November 1, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants