New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#161669901 Change error Message #23

Merged

KMaina merged 1 commit into develop from ch-fix-error-messages-161669901

Nov 2, 2018

Owner

KMaina commented Nov 2, 2018

What does this PR do?

Change error key from msg to success

Description of Task to be completed?

Have more descriptive error codes

How should this be manually tested?

Clone the repo locally
Create virtual environment and run pytest
In Postman supply invalid values and have the key of those error messages being error

Any background context you want to provide?

None

What are the relevant pivotal tracker stories?


          [Chore #161669901] Change error message keys

a621ddd

coveralls commented Nov 2, 2018

Pull Request Test Coverage Report for Build 132

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.495%

Totals
Change from base Build 130:	0.0%
Covered Lines:	1099
Relevant Lines:	1228

💛 - Coveralls

KMaina merged commit 3df2cda into develop

KMaina deleted the ch-fix-error-messages-161669901 branch

November 2, 2018 01:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment