Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ending cutscene for Light Side - Multiple issues #186

Closed
16 of 17 tasks
DarthParametric opened this issue Jun 6, 2019 · 6 comments
Closed
16 of 17 tasks

Ending cutscene for Light Side - Multiple issues #186

DarthParametric opened this issue Jun 6, 2019 · 6 comments
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Stunt Issue occurs primarily in one of the various cutscene stunt modules Type: Asset This issue is related to specifically to an asset like a model, texture, etc. Type: Scripting This issue is related specifically to a scripting bug/error Type: Widescreen This issue is specifically related to widescreen framing making unintended objects visible

Comments

@DarthParametric
Copy link
Contributor

DarthParametric commented Jun 6, 2019 •
edited
Loading

There are a few minor issues in this scene. Some due to widescreen framing issues, others due to stunt animations.

  • The module is using unique low res textures for everything, even though the assets are reused. Probable Xbox-specific performance related change.
  • Zaalbar has animations for two vocalisations at the start of the scene, but only a single SFX plays.
  • The second time Zaalbar vocalises (towards the end in a wide shot) he has three distinct barks, but only animates for two.
  • Dodonna blocks the Council in a number of shots.
  • Bastila seems to constantly change position between shots, including being absent altogether from at least one shot.
  • Jolee and Mission both disappear from some of the wide shots.
  • HK-47 has his arms out in an awkward A-pose instead of relaxed against his body.
  • HK-47 is obscured or missing in certain wide shots.
  • Juhani is obscured in one wide shot.
  • Canderous' arm clips into Zaalbar during one wide shot.
  • Dodonna and one of the Council members can be seen floating off the ground in the background of the Vandar wide shots.
  • T3-M4/HK/Juhani/Mission/Jolee/Carth visibly float above the ground in at least one shot.
  • Carth has his meme-tastic derp smile.
  • In the final shot, it looks like the PC rises out of the ground. Edit: Appears to be related to stunt model's cutscenedummy / rootdummy position? Partially resolved/mitigated.
  • Many shots have dead space at the sides due to being originally framed for 4:3, but now appearing in 16:9 / 16:10.
  • Some characters appear to be static in certain wide shots.
  • ❌ When turning to face Dodonna, the player seems to oddly step sideways instead of turning on the spot.

Module is STUNT_57.
@DarthParametric DarthParametric added Type: Widescreen This issue is specifically related to widescreen framing making unintended objects visible Minor Issue Aesthetic issue or other problem that isn't really a bug Type: Asset This issue is related to specifically to an asset like a model, texture, etc. Module: Stunt Issue occurs primarily in one of the various cutscene stunt modules labels Jun 6, 2019
@DarthParametric
Copy link
Contributor Author

DarthParametric commented Jun 6, 2019 •
edited
Loading

The HK arm issue appears to be caused by the stunt model having an incorrect hierarchy. Curiously though, the problem was the head being a direct child of the neck rather than having a dummy in between. The arm bones were actually OK, but apparently the hierarchy change was enough to cause them not to inherit any animation. Rejigging the hierarchy (and changing the head height offsets in the animations to account for the added dummy) fixes the problem:

HK_A-Pose_Fix

@DarthParametric
Copy link
Contributor Author

DarthParametric commented Jun 7, 2019 •
edited
Loading

Some minor camera position adjustment masks the floating Dodonna/Council:

LS_Cutscene_Adjustment

@DarthParametric
Copy link
Contributor Author

Carth has been de-memed:

Carth_Smile_Meme_Removal

@DarthParametric
Copy link
Contributor Author

Thoughts @JCarter426 @Mako88 ?

https://www.youtube.com/watch?v=BC-MJtIzN3s

@DarthParametric DarthParametric added the Type: Scripting This issue is related specifically to a scripting bug/error label Jun 10, 2019
@JCarter426
Copy link
Contributor

Looks good.
If you upload the ASCII files, I can take a look at why that transition at the end still happens, at some point. But it's far less noticeable than the original anyway.

@DarthParametric
Copy link
Contributor Author

Final (hopefully) version - https://youtu.be/AssYEa9wXSY

DarthParametric added a commit that referenced this issue Nov 5, 2019
@DarthParametric
Addendum for #186 switching Zhar and Vrook's robes for LS ending. Fixes
e96a6ea 
#323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Minor Issue Aesthetic issue or other problem that isn't really a bug Module: Stunt Issue occurs primarily in one of the various cutscene stunt modules Type: Asset This issue is related to specifically to an asset like a model, texture, etc. Type: Scripting This issue is related specifically to a scripting bug/error Type: Widescreen This issue is specifically related to widescreen framing making unintended objects visible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DarthParametric @JCarter426