Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a new file Goalie_2.py #59

Open
wants to merge 3 commits into
base: fsm
Choose a base branch
from

Conversation

hardik-kgp
Copy link
Contributor

No description provided.

tactics/Goalie_2.py Outdated Show resolved Hide resolved
tactics/Goalie_2.py Outdated Show resolved Hide resolved
tactics/Goalie_2.py Outdated Show resolved Hide resolved
#expected_y = goalie_expected_y(state, self.kub.kubs_id)
if state.ballVel.x < -10:
#angle = state.ballVel.y/state.ballVel.x
angle = math.atan(state.awayPos[state.opp_bot_closest_to_ball].theta)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it is better not to use state.opp_bot_closest_to_ball here as it was removed as an unwanted belief state recently by @shamin1998 . @shamin1998 do we still have opp_bot_closest_to_ball variable in BS? Is the computation reliable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd removed the variables that weren't being used at the time. But I guess we'll need opp_bot_closest_to_ball for role selector, I'll put it back in

@thebhatman
Copy link
Member

I am concerned about opp_bot_closest to ball here. Change that, maybe you can find out the closest opponent bot, when required. Don't use the variable from belief state.

@hardik-kgp
Copy link
Contributor Author

hardik-kgp commented May 25, 2019

I have removed the issues and committed the changes.

@saurabhkgp21
Copy link
Member

Do we need this goalie or old goalie code is in use?

@thebhatman
Copy link
Member

Parth had written a goalie code. Right now that is in use.

@saurabhkgp21
Copy link
Member

So no need to keep this open I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants