Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 Download will not work on specific songs #644

Closed
1 task done
Verizane opened this issue Aug 21, 2023 · 3 comments
Closed
1 task done

Windows 10 Download will not work on specific songs #644

Verizane opened this issue Aug 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Verizane
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

My Download usually works, but on some tracks I get the following errors:

------- DEVICE INFO -------
computerName:
numberOfCores: 16
systemMemoryInMegabytes: 32768
------- APP INFO -------
environment: release
version: 3.1.0
appName: spotube
buildNumber:
packageName: spotube
---------- ERROR ----------
FileSystemException: Cannot create file, path = 'C:\Users\xxxxx\Downloads\Spotube\Song of Storms (from "The Legend of Zelda: Ocarina of Time") - Epic Version - L'Orchestra Cinematique, Alala.m4a.partial.temp0' (OS Error: Die Syntax für den Dateinamen, Verzeichnisnamen oder die Datenträgerbezeichnung ist falsch.
, errno = 123)
------- STACK TRACE -------
#0 _File.throwIfError (dart:io/file_impl.dart:675)
#1 _File.createSync (dart:io/file_impl.dart:306)
#2 DioForNative.download (package:dio/src/dio/dio_for_native.dart:86)

#3 ChunkDownload.chunkedDownload.downloadChunk (package:spotube/services/download_manager/chunked_download.dart:44)

#4 ChunkDownload.chunkedDownload (package:spotube/services/download_manager/chunked_download.dart:77)

#5 DownloadManager.download (package:spotube/services/download_manager/download_manager.dart:116)

#6 DownloadManager._startExecution (package:spotube/services/download_manager/download_manager.dart:393)

------- CUSTOM INFO -------

Expected Behavior

It should have downloaded correctly, but the name seems to interfere.

Steps to reproduce

  1. Installed Spotube
  2. Opened it
  3. Played some Songs, click on download, tried to download from playlist, tried to download when first playing etc.

Operating System

Windows 10

Spotube version

v3.1.0

Installation source

GitHub Releases (Binary)

Additional information

No response

@Verizane Verizane added the bug Something isn't working label Aug 21, 2023
@Verizane
Copy link
Author

Ah of course, quotes like "" are not allowed, i just tried via filesystem!

@KRTirtho
Copy link
Owner

Wow that's good catch. I didn't even know quotes were allowed on Spotify titles. We've to make sure to clean up the filename before saving on the next release.

@KRTirtho
Copy link
Owner

Fixed in v3.1.1

meenbeese pushed a commit to meenbeese/spotube that referenced this issue Sep 20, 2023
meenbeese pushed a commit to meenbeese/spotube that referenced this issue Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Deployed
Development

No branches or pull requests

2 participants