Draft: PPT mode #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gn with wamp spec
|
|
||
| @override | ||
| bool Verify() { | ||
| if (timeout! < 0) { |
There was a problem hiding this comment.
Timeout possibly null at this point?
| @@ -25,7 +25,7 @@ class Subscribed extends AbstractMessage { | |||
| return _revokeCompleter.future; | |||
| } | |||
|
|
|||
| /// Is called by the session when the revokation happens | |||
| /// Is called by the session when the revocation happens | |||
There was a problem hiding this comment.
This is what's currently breaking the build. revoke is calling compete with a nullable String, while the completer is a non-nullable string.
|
Main comment I have is that most things appear to be marked as nullable and there's liberal use of ! that assumes the data is not null. I haven't looked through the rest of the Connectanum code, so unsure if this is the norm here. |
|
Closing as this became obsolete: upstream made some updates and merged, our own fork also went ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress implementation of PPT Mode in lib for review and discussions