NetKAN-bot Rewrite #19
Conversation
|
Messed up the rebase/pull. But it's merge friendly again. |
|
Oh goodness, that commit history is really up the creek. Looks fine locally though O.o |
| # TODO: I think Git::Wrapper has a way to do this natively | ||
| # TODO: If not, wrap it in a try/catch | ||
| if ($self->shallow) { | ||
| system("git", "clone", "--depth", "1", $self->remote, $self->local."/".$self->working); |
There was a problem hiding this comment.
Git seems to give me a warning, when I'm running test cases, which may be related to this line.
warning: --depth is ignored in local clones; use file:// instead.
But that's not enough to be a blocker
There was a problem hiding this comment.
Yeah, we use remotes and the test isn't specifically checking the depth of the pull, just that we can perform it. I will add a comment to the test.
|
@techman83 : I've added a couple more line comments, but they're more things which affect our tests rather than anything else. It looked last my past self was pretty happy with this, and if the bot has issues we can always roll it back, and this is way better than our past architecture, so you should:
It's silly for things like this to be delayed because I've been busy, and changes to our indexing and build systems are relatively low-risk compared to changes to our clients. Thank you so much for your patience! |
|
Thanks for the review :-) |
This is a full re-architect of the NetKAN indexing bot. It has feature parity (maybe slightly more) with the original single script.
closes #1
closes #3
closes #4
closes #5
closes #8
fixes #10